app/api/connectedAccounts/googleSheets/refresh/route.ts (1)

40-48: Fragile error classification using string matching.

Determining status code by checking if error message includes "not found" is brittle. If the underlying error message format changes or if other errors contain "not found", this will misclassify them.

Consider having refreshConnectedAccount throw typed errors or use error codes instead.

Example: Custom error classes

In a shared errors file:

export class NotFoundError extends Error {
  constructor(message: string) {
    super(message);
    this.name = 'NotFoundError';
  }
}

Then in the route:

   } catch (error) {
     const errorMessage =
       error instanceof Error ? error.message : "Internal server error";
-    const statusCode = errorMessage.includes("not found") ? 404 : 500;
+    const statusCode = error instanceof NotFoundError ? 404 : 500;

     return NextResponse.json(
       { error: errorMessage },
       { status: statusCode, headers: getCorsHeaders() },
     );
   }

app/api/connectedAccounts/googleDrive/refresh/route.ts (2)

40-48: Fragile error classification using string matching (duplicated pattern).

This error handling pattern is identical to the Google Sheets refresh route. Determining status code by checking if error message includes "not found" is brittle and duplicated across routes.

Consider having refreshConnectedAccount throw typed errors, and potentially extracting the common error handling logic into a shared utility.

Example: Shared error handler

Create a shared handler in lib/api/errorHandlers.ts:

export function handleRefreshError(error: unknown): { error: string; status: number } {
  if (error instanceof NotFoundError) {
    return { error: error.message, status: 404 };
  }
  const errorMessage = error instanceof Error ? error.message : "Internal server error";
  return { error: errorMessage, status: 500 };
}

Then in both routes:

   } catch (error) {
-    const errorMessage =
-      error instanceof Error ? error.message : "Internal server error";
-    const statusCode = errorMessage.includes("not found") ? 404 : 500;
-
+    const { error: errorMessage, status: statusCode } = handleRefreshError(error);
+    
     return NextResponse.json(
       { error: errorMessage },
       { status: statusCode, headers: getCorsHeaders() },
     );
   }

---

1-50: Consider extracting common route logic.

The Google Drive and Google Sheets refresh routes are nearly identical except for the toolkit key ("GOOGLE_DRIVE" vs "GOOGLE_SHEETS"). This duplication could be reduced with a shared handler or route factory.

Example: Shared route handler

Create lib/api/createRefreshRoute.ts:

export function createRefreshRouteHandler(toolkitKey: ComposioToolkitKey) {
  return async function POST(request: NextRequest) {
    try {
      const body = await request.json();
      const { accountId, redirectUrl } = body;

      if (!accountId) {
        return NextResponse.json(
          { error: "accountId is required" },
          { status: 400, headers: getCorsHeaders() },
        );
      }

      const response = await refreshConnectedAccount(
        toolkitKey,
        accountId,
        redirectUrl,
      );

      return NextResponse.json(
        { message: "Connected account refreshed successfully", ...response },
        { status: 200, headers: getCorsHeaders() },
      );
    } catch (error) {
      // ... error handling
    }
  };
}

Then in each route:

export const POST = createRefreshRouteHandler("GOOGLE_DRIVE");

lib/composio/refreshConnectedAccount.ts (1)

17-17: Consider making the API base URL configurable.

The hardcoded Composio API base URL limits flexibility for testing and different environments. Consider moving this to an environment variable (e.g., COMPOSIO_API_BASE_URL) with the current value as a fallback default.

♻️ Suggested improvement

-const COMPOSIO_API_BASE_URL = "https://backend.composio.dev";
+const COMPOSIO_API_BASE_URL = process.env.COMPOSIO_API_BASE_URL || "https://backend.composio.dev";

Configuration used: defaults

Review profile: CHILL

Plan: Pro